-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for Upgrade Handler #131
Conversation
} | ||
|
||
var ( | ||
SecondaryDenom = "uion" |
Check warning
Code scanning / Revive (reported by Codacy)
exported var SecondaryDenom should have comment or be unexported
"github.com/White-Whale-Defi-Platform/migaloo-chain/app" | ||
) | ||
|
||
type KeeperTestHelper struct { |
Check warning
Code scanning / Revive (reported by Codacy)
exported type KeeperTestHelper should have comment or be unexported
@@ -0,0 +1,154 @@ | |||
package apptesting |
Check warning
Code scanning / Revive (reported by Codacy)
should have a package comment
return testAddrs | ||
} | ||
|
||
func GenerateTestAddrs() (string, string) { |
Check warning
Code scanning / Revive (reported by Codacy)
exported function GenerateTestAddrs should have comment or be unexported
@@ -213,6 +213,81 @@ | |||
return app | |||
} | |||
|
|||
func GenesisStateWithValSet(app *MigalooApp) GenesisState { |
Check warning
Code scanning / Revive (reported by Codacy)
exported function GenesisStateWithValSet should have comment or be unexported
return validAddr, invalidAddr | ||
} | ||
|
||
// Mints and sends coins to a user account |
Check warning
Code scanning / Revive (reported by Codacy)
comment on exported method KeeperTestHelper.FundAccount should be of the form "FundAccount ..."
return sdk.NewContext(ms, tmtypes.Header{}, false, logger), ms | ||
} | ||
|
||
// CreateTestContext creates a test context. |
Check warning
Code scanning / Revive (reported by Codacy)
comment on exported method KeeperTestHelper.Commit should be of the form "Commit ..."
s.TestAccs = CreateRandomAccounts(3) | ||
} | ||
|
||
func (s *KeeperTestHelper) SetupTestForInitGenesis() { |
Check warning
Code scanning / Revive (reported by Codacy)
exported method KeeperTestHelper.SetupTestForInitGenesis should have comment or be unexported
s.FundAccount(acc, amounts) | ||
} | ||
|
||
func (s *KeeperTestHelper) ConfirmUpgradeSucceededs(upgradeName string, upgradeHeight int64) { |
Check warning
Code scanning / Revive (reported by Codacy)
exported method KeeperTestHelper.ConfirmUpgradeSucceededs should have comment or be unexported
tests are so good! In the future, if codacy tags something to be addressed, please address it. For now, lgtm |
Description and Motivation