Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: uses procedural macro to replace the MigrateInvalidVersion on V2 contracts #373

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

kerber0x
Copy link
Contributor

@kerber0x kerber0x commented Jul 3, 2024

Description and Motivation

This PR uses the macro from https://crates.io/crates/cw-migrate-error-derive to generate the previous MigrateInvalidVersion across all the V2 contracts.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (2f40957) to head (6956598).
Report is 2 commits behind head on release/v2_contracts.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #373      +/-   ##
========================================================
+ Coverage                 90.90%   90.93%   +0.02%     
========================================================
  Files                       280      280              
  Lines                     31830    31917      +87     
========================================================
+ Hits                      28936    29023      +87     
  Misses                     2894     2894              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x merged commit 07800ca into release/v2_contracts Jul 3, 2024
7 checks passed
@kerber0x kerber0x deleted the feat/migrate-error-macro branch July 3, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant