Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types for Box and Sphere components #267

Closed
2 of 19 tasks
hirako2000 opened this issue Jul 2, 2017 · 1 comment
Closed
2 of 19 tasks

Types for Box and Sphere components #267

hirako2000 opened this issue Jul 2, 2017 · 1 comment
Assignees
@hirako2000
Labels
ENHANCEMENT
Milestone
v2.1.0

Comments

@hirako2000
Copy link
Collaborator

We are now providing a few types, but ts projects now using whs will fail to compile as certain classes are not defined (they pull whs provided definitions automatically).

Provide types for

  • Box
  • Sphere
Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
@hirako2000 hirako2000 self-assigned this Jul 2, 2017
hirako2000 added a commit that referenced this issue Jul 2, 2017
@hirako2000
Adds types for Sphere and Box - adjusts MeshComponent and use inherit…
ea5996b 
…ance for params - #267
This was referenced Jul 2, 2017
Merged
Closed
@hirako2000 hirako2000 added this to the v2.0.1 milestone Jul 2, 2017
hirako2000 added a commit that referenced this issue Jul 2, 2017
@hirako2000
Merge pull request #268 from WhitestormJS/#267
e2da432 
PR for #267
@hirako2000
Copy link
Collaborator Author

Continued with #269

@sasha240100 sasha240100 modified the milestones: v2.1.0, v2.0.1 Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirako2000 hirako2000

Labels
ENHANCEMENT
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
2 participants
@hirako2000 @sasha240100