Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Tube, Torus, Torusknot, Terahedron type definitions - #297 #299

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Adding Tube, Torus, Torusknot, Terahedron type definitions - #297 #299

merged 1 commit into from
Jul 17, 2017

Conversation

ChaseWhite3
Copy link

Please review

@sasha240100
Copy link
Member

/ping @hirako2000

hirako2000
hirako2000 approved these changes Jul 17, 2017
View reviewed changes
Copy link
Collaborator

@hirako2000 hirako2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, well done!
Nicely documented and all.

@hirako2000
Copy link
Collaborator

We could add some test as I do. but not major. I sometimes catch a few mistakes when I write the test, good safety measure to make sure the types are as expected.

@sasha240100 sasha240100 merged commit 0d70c54 into dev Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirako2000 hirako2000 hirako2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaseWhite3 @sasha240100 @hirako2000