Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for #297 #311

Merged
merged 16 commits into from
Jul 31, 2017
Merged

PR for #297 #311

merged 16 commits into from
Jul 31, 2017

Conversation

hirako2000
Copy link
Collaborator

It's a lot.

I suggest to just glance over it and improve later where appropriate.

sasha240100
sasha240100 reviewed Jul 30, 2017
View reviewed changes
types/components/meshes/Dodecahedron.d.ts
} from 'three';

/**
* this is missing in @types from three.js :(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we add such things to separate file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best would be to fix @types/three imo.
Unless there is a reason they don't provide interfaces for certain buffer geometries...

sasha240100
sasha240100 reviewed Jul 30, 2017
View reviewed changes
Copy link
Member

@sasha240100 sasha240100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few code style fixes

types/components/meshes/index.d.ts
export * from './Group';
export {Dodecahedron} from './Dodecahedron';
export * from './Extrude';
export {Icosahedron} from './Icosahedron';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is special with Dodecahedron and Icosahederon so they are exported different way ?

Copy link
Collaborator Author

@hirako2000 hirako2000 Jul 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because I didn't want to export other class/interfaces from Dode/Ico.

types/whs-tests.ts
},

buffer: true
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you fixed those right?

types/whs-tests.ts Outdated
thetaSegments: 10,
thetaStart: 0
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

types/whs-tests.ts
},

buffer: true
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

types/whs-tests.ts
},

buffer: true
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

types/whs-tests.ts
},

buffer: true
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

types/whs-tests.ts
},

buffer: true
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

types/whs-tests.ts
},

buffer: true
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

types/whs-tests.ts
geometry: {
points: [new Vector2(1, 1)]
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

types/whs-tests.ts
radius: 2,
detail: 0.2
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

@sasha240100
Fixed code style
d02dab1 
- Removed deprecated useCustomMaterial
- Fixed line padding
@sasha240100
Merge branch 'dev' into #297
e717ad5
@sasha240100
Copy link
Member

@hirako2000 Fixed code style & updated branch.

@hirako2000
Copy link
Collaborator Author

Thanks, I think we are fine to merge this. we can clean up better as we go along. I intend to do some proper testing with the typescript boilerplate. Im sure I will find some issues with some types.

@sasha240100 sasha240100 merged commit ddd0753 into dev Jul 31, 2017
@sasha240100 sasha240100 deleted the #297 branch July 31, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha240100 sasha240100 sasha240100 left review comments

@ChaseWhite3 ChaseWhite3 Awaiting requested review from ChaseWhite3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hirako2000 @sasha240100