Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull dependencies from CodeArtifact in the circleci workflow #3

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

junyifang-whoop
Copy link

As part of the work to migrate away from Nexus to CodeArtifact, we've backfilled CodeArtifact to have all existing packages in Nexus and have been publishing all new packages to CodeArtifact. We should pull dependencies from CodeArtifact instead of Nexus now so that we can eventually tear down Nexus.

The javascript/pull-auth command defined in the web orb controls the remote repository to pull dependencies from (currently set to pulling from CodeArtifact). The javascript/publish command covers all steps needed to publish to remote repository.

Copy link

@swarajrao swarajrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably already know this but I think this is the repo that breaks storefront-gatsby? So might need to loop in Kevin when merging or have a PR for dependent repos ready

@junyifang-whoop
Copy link
Author

you probably already know this but I think this is the repo that breaks storefront-gatsby? So might need to loop in Kevin when merging or have a PR for dependent repos ready

Great call out! I don't think merging this PR in will affect storefront-gatsby as it is relying on a specific version (2.20.0-whoop.0.0.2-beta1), which won't get modified by this PR merging. But it doesn't hurt to give a heads up

@junyifang-whoop junyifang-whoop merged commit 9472531 into master Oct 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants