Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Replace delete with del in method list #3

Closed
wants to merge 2 commits into from

Conversation

alavers
Copy link

@alavers alavers commented Jun 24, 2014

No description provided.

@benesch
Copy link
Contributor

benesch commented Jun 26, 2014

Ah, nice catch.

So, for whatever reason, SuperTest aliases del to delete, and exposes both methods. That doesn't seem to be true of SuperAgent. I'd rather be consistent with SuperTest, since that's our direct parent.

If you could update your PR to do a SuperTest-style alias, I'm happy to merge! Otherwise I'll try to get to this as soon as I have a free minute.

@benesch
Copy link
Contributor

benesch commented Jun 26, 2014

(The change seems to be intentional, too. See visionmedia/supertest#87412836)

@alavers
Copy link
Author

alavers commented Jun 27, 2014

Let me know if this works

@benesch benesch closed this in 5e9b8e5 Jul 1, 2014
@benesch
Copy link
Contributor

benesch commented Jul 1, 2014

Great, thanks!

Sorry for the delay in merging. I wanted to ensure stuff like this doesn't happen in the future by running upstream's tests against SuperTest as Promised directly, which required some retooling. Had I done this from the beginning, I would have noticed upstream's ".del should work" test was failing. It now passes!

Looks like we're now 100% compatible with SuperTest's API. Provided their test suite is complete, of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants