Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsing exception if team strength is decimal #93

Closed
StegSchreck opened this issue Nov 19, 2016 · 4 comments
Closed

parsing exception if team strength is decimal #93

StegSchreck opened this issue Nov 19, 2016 · 4 comments
Assignees
@Sh4kE @StegSchreck
Labels
bug
Milestone
0.2

Comments

@StegSchreck
Copy link
Member

StegSchreck commented Nov 19, 2016 •
edited
Loading

models.py:403 MatchTeamStatistics
strength = models.IntegerField(default=0)

has to be changed to DecimalField

blocked by #49
@StegSchreck StegSchreck added this to the 0.2 milestone Nov 19, 2016
@Sh4kE
Copy link
Member

Sh4kE commented Nov 19, 2016 •
edited by StegSchreck
Loading

And why is it blocked by #49?

@StegSchreck
Copy link
Member Author

same reason you fixed the country bug in that branch. because of the squashed migrations.

@Sh4kE
Copy link
Member

Sh4kE commented Nov 19, 2016 •
edited by StegSchreck
Loading

It's already merged into the master

@StegSchreck
Copy link
Member Author

no review? ok...

StegSchreck added a commit that referenced this issue Nov 19, 2016
@StegSchreck
#93 fixed decimal strength parsing error
65445a9
StegSchreck referenced this issue Nov 26, 2016
@Sh4kE
convert strings to floats now
ee9d733
StegSchreck referenced this issue Nov 26, 2016
@StegSchreck
fixed strength slider filter
dff34a5
StegSchreck referenced this issue Nov 26, 2016
@StegSchreck
only show decimals for strength, if it is not 0
8674b0e
StegSchreck referenced this issue Nov 26, 2016
@StegSchreck
format percentage numbers with comma as decimal separator
673530f
StegSchreck referenced this issue Nov 26, 2016
@StegSchreck
fixed unit tests which should have failen on travis already
381f04c
StegSchreck referenced this issue Nov 26, 2016
@StegSchreck
travis has a different prefered locale...
9d9d827
StegSchreck referenced this issue Nov 26, 2016
@StegSchreck
fuck travis
62b5c1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sh4kE Sh4kE

@StegSchreck StegSchreck

Labels
bug
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@Sh4kE @StegSchreck