Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign Alerts list is not shown on mobile #1856

Closed
ragesoss opened this issue Apr 18, 2018 · 4 comments · Fixed by #1859
Closed

Campaign Alerts list is not shown on mobile #1856

ragesoss opened this issue Apr 18, 2018 · 4 comments · Fixed by #1859

Comments

@ragesoss
Copy link
Member

When it switches to mobile layout, the list just disappears: https://outreachdashboard.wmflabs.org/campaigns/artfeminism_2018/alerts

@wendyyuchensun
Copy link
Contributor

Hi @ragesoss, I'm Wendy, a web developer from Taiwan. I came across this issue few days ago and found that I can fix it. I've created a pull request. Hope it helps!

@ragesoss
Copy link
Member Author

ragesoss commented Apr 24, 2018 via email

@wendyyuchensun
Copy link
Contributor

@ragesoss Let me have a look. I'll get back to you asap. :)

@wendyyuchensun
Copy link
Contributor

wendyyuchensun commented Apr 24, 2018

Hi @ragesoss, the Article list should be fine. It does not contain any <Alert /> component, which is what I've changed.

The only place where <Alert /> is used is in the alert table, so I think the PR won't affect any other thing on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants