4. feature/transferring training modules between categories #5889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omChauhanDev
force-pushed
the
feature/transfer-module-between-categories
branch
from
b8cc760
to
1a3de22
Compare
TheTrio
reviewed
Jul 8, 2024
app/assets/javascripts/actions/training_modification_actions.js
Outdated
Show resolved
Hide resolved
TheTrio
reviewed
Jul 8, 2024
TheTrio
reviewed
Jul 8, 2024
app/assets/javascripts/training/components/modals/transfer_step3.jsx
Outdated
Show resolved
Hide resolved
|
I tested this out, and it worked smoothly. |
omChauhanDev
changed the title
TheTrio
reviewed
Jul 13, 2024
app/assets/javascripts/training/components/modals/transfer_step3.jsx
Outdated
Show resolved
Hide resolved
TheTrio
reviewed
Jul 13, 2024
app/assets/javascripts/training/components/modals/transfer_step2.jsx
Outdated
Show resolved
Hide resolved
|
The code looks better now, some minor refactoring and we should be good to go |
|
@TheTrio Kindly, have a look. As i have now incorporated all the changes suggested by you. |
TheTrio
reviewed
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pr added functionality for transferring modules between categories within the same library.
Added rspec test for this functionality
Screenshots
Before:
After:
Transfer Button on the training library page
Modal for selecting 'source category'
Modal for choosing 'modules' to transfer
Modal for selecting 'destination category'
Result after transferring training module between categories
