Runtime Improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not using it, and it causes the jar to hang when spark-submitted in certain cases, breaking scripting workflows.
In certain cases, the script would still not exit cleanly after finishing the ingest, despite removing Hive support. This explicit call to sys.exit(0) ensures that it does.
jpolchlo
approved these changes
Nov 27, 2023
|
Thanks for reviewing! In my testing, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Hive support. We're not using it, and it causes the jar to hang when spark-submitted in certain cases, breaking scripting workflows.
Also add explicit exit command. In certain cases, the script would still not exit cleanly after finishing the ingest, despite removing Hive support. This explicit call to
sys.exit(0)ensures that it does.