Initial App Import #2
Conversation
|
The app behavior looked fine, but it might be notable that |
|
|
||
| ARGS=$* | ||
|
|
||
| vagrant ssh -c "cd /vagrant/src/app/ && npm $ARGS" |
There was a problem hiding this comment.
Is this script necessary any longer, considering that we now have update and server?
| @@ -19,6 +19,6 @@ then | |||
| then | |||
| usage | |||
| else | |||
| npm run start | |||
| vagrant ssh -c "cd /vagrant/dist/ && python -m SimpleHTTPServer 8000" | |||
There was a problem hiding this comment.
Is there a reason we need to execute this outside of the VM? The convention we have been following for these scripts (update, server, etc.) has been to execute them within the context of the VM, so we shouldn't need to wrap these commands with vagrant ssh ..., right?
There was a problem hiding this comment.
Removed vagrant ssh wrapper, this is now expected to be run from within.
| "type": "git", | ||
| "url": "git+https://github.com/WikiWatershed/mmw-micro.git" | ||
| }, | ||
| "author": "Azavea Inc.", |
There was a problem hiding this comment.
Consider changing author to just "Azavea".
| @@ -21,6 +21,6 @@ then | |||
| else | |||
| ./scripts/update.sh | |||
| ./scripts/test.sh | |||
| npm run bundle | |||
| ./src/app/bundle.sh --vendor --minify | |||
There was a problem hiding this comment.
I think the bundle script should be called from update. Maybe we can use a "production" environment variable to indicate that minification needs to happen.
|
Can we change this so that running |
rajadain
force-pushed
the
feature/tt/initial-app-import
branch
from
d997b87 to
d07934a
Compare
|
Updated according to all feedback. Starting with a fresh checkout of the repo, |
|
+1 |
| ```bash | ||
| $ vagrant ssh | ||
| $ ./scripts/server.sh | ||
| $ ./scripts/server.ssh |
rajadain
force-pushed
the
feature/tt/initial-app-import
branch
from
d07934a to
c45cdd4
Compare
Overview
Imports micro site from Model My Watershed. Sets up basic bundling into
/dist.Notes
In an effort to minimize the difference during import, I've tried to keep the scripts consistent with what they were in Model My Watershed. However, they are now inconsistent with all our other projects which run scripts from within the VM, rather than from outside. I'm making cards to address this in the future.
We probably don't need the
--vendorflag in the bundling script anymore. That is also a holdover from Model My Watershed and should be removed.Apparently we minify only JavaScript, not any of the CSS. We should look into minifying CSS. Also, I just copied over the entire SASS directory from Model My Watershed. We can probably lose a lot of that.
Maybe we shouldn't be exporting to the
/distfolder and serving from there for development? This was the easiest thing to do right now, but I feel/distshould only be used for production builds.Even though this is going to be on a CDN, there's still a lot of files being requested. We should look into using CSS rather than Retina.js for serving higher resolution images to reduce the number of requests, and maybe also look into CSS sprites if that is not enough.
Testing Instructions
Check out this branch. Reload Vagrant so it picks up on new server port mapping. Then run the bundle script:
Open localhost:8000 in a browser and test that the app works identically to the one on staging, and that there are no errors in the console.
Connects WikiWatershed/model-my-watershed#1483