Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HydroShare Integration Issues #3489

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Mar 1, 2022

Overview

Observed in production, these issues with integrating with HydroShare are a result of the Django upgrades, and of browser policy changes.

The fixes in this PR make the full HydroShare workflow function correctly again.

Connects #3440
Connects #3463

Testing Instructions

Setup

  • Find and edit the HydroShare OAuth MMW Beta entry in LastPass
  • Copy the value of client-secret, qxt...oj5
  • Use it to initialize the variable in the app VM:
    vagrant ssh app -c 'echo qxt...oj5 | sudo tee /etc/mmw.d/env/MMW_HYDROSHARE_SECRET_KEY'
    vagrant ssh app -c 'sudo service mmw-app restart'

Testing

rajadain added 5 commits March 1, 2022 17:03
As required by recent Django upgrades
Also changed in one of the Django upgrades
Previously we used iframes for logging users into HydroShare,
which was convenient and friendly, and worked in all modern
browsers. For IE which did not allow third party cookies in
iframes, necessary for HydroShare login, we fellback to a
full-page experience.

As of recent times, Chrome no longer allows third party
cookies in iframes either. So, we remove the iframe flow
entirely, and replace all of it with the fallback. Not as
elegant as before, but functional.

Refs #3440
Since this is no longer used, the iframe specific code is
removed.
Copy link
Contributor

@emilyhu0106 emilyhu0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linking and sharing experience is very smooth! Nice work!

@rajadain rajadain merged commit 9947768 into release/1.33.4 Mar 3, 2022
@rajadain rajadain deleted the tt/fix-hydroshare-project-creation branch March 3, 2022 02:44
@rajadain
Copy link
Member Author

rajadain commented Mar 3, 2022

Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants