Enable Recent Weather in DRWI #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DRWI includes DRB and some neighboring HUCs in New Jersey. Instructions for how this was made are in the README. This will be used for recent weather stations.
Since we use the boundary check both in the back- and front-ends, we need to wire it through to be available in both places.
This is not the most sustainable design, but will do for now. Just like the `in_drb` attribute, we add a new one that checks if the project is in the DRWI region. This is also added to the weather modal's WindowModel, since that will need this information for correct rendering of simulated weather options.
This will show a grayed out box with appropriate message for DRWI and DRB-specific Simulated Weather options given the AoI. These boundaries will also be enforced at the API level.
rachelekm
approved these changes
Oct 17, 2022
| done for `drb_simple_perimeter`. The file was then manually edited to remove | ||
| the `GeometryCollection` parent, keeping only the `Polygon` value. | ||
|
|
||
| Finally, this was Unioned and Dissolved with the `drb_simple_perimeter` in QGIS |
| distance = 3, | ||
| unit = 'miles', | ||
| drwiBuf = turfBuffer(drwi, distance, unit); | ||
|
|
There was a problem hiding this comment.
Can this be combined into a general purpose buffer script with DRB or DRWI flag arguments to set the path variables or is it better to have this as a separate script?
There was a problem hiding this comment.
It probably could be parameterized into a single script, but since different shapes could have different buffer radii based on their size and shape, and there's little else in these files but those variables, I decided to keep them separate.
|
Thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Copy of #3548, for the hotfix.
Closes #3569
Testing Instructions
bundle.sh --debug