Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for Analyzing Global Land #3637

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jul 29, 2024

Overview

Adds UI for analyzing global land cover layer. Currently we only do it for 2023. The global land cover
charts have less margin on the left, because the category names are shorter. Global land cover analysis is also optional, so it doesn't fire by default.

Also disables the Future Land analysis from running by default, because that has been broken for more than a year now.

Closes #3636

Demo

2024-07-29.13.25.19.mp4

Testing Instructions

  • Check out this branch and ./scripts/bundle.sh --debug
  • Go to http://localhost:8000/
  • Select / draw an area and move to Analyze
  • Go to the land tab
  • Select the Global Land Use 2023 item from the dropdown
    • Ensure the analysis for that starts when you select the item
    • Ensure it completes
    • Ensure chart looks good
    • Ensure table looks good
    • Ensure download CSV behavior works correctly

Marking analyses as lazy makes them not execute until they are
selected by users. Given that the Drexel / ANS endpoint that
powers these anlayses has been broken for a long time, it does
not serve to have them execute by default for every run. This
edit makes it so that they don't.
Currently we only do it for 2023. The global land cover
charts have less margin on the left, because the category
names are shorter. Global land cover analysis is also
optional, so it doesn't fire by default.
@rajadain rajadain added the AWS Funding Source: AWS label Jul 29, 2024
@rajadain rajadain requested a review from rachelekm July 29, 2024 17:31
Copy link
Contributor

@rachelekm rachelekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We paired on testing this branch, confirming here that the analysis and UI look good to go and CSV is as expected!

@rajadain rajadain merged commit e2b1903 into develop Aug 1, 2024
2 checks passed
@rajadain rajadain deleted the tt/3636/add-ui-for-analyzing-global-land branch August 1, 2024 15:40
@rajadain
Copy link
Member Author

rajadain commented Aug 1, 2024

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWS Funding Source: AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS 2-4: Add UI for Analyzing Global Land
2 participants