Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for initial app setup #1

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Alonkad
Copy link
Collaborator

@Alonkad Alonkad commented Feb 12, 2022

Description

This PR fixes multiple issues with initial setup of the app:

  • MongoDB deprecation warnings
  • Node deprecation warning
  • createBrowserHistory deprecation warning
  • Adding .env file to .gitignore
  • Fixing error with HMR (I went with this fix)
  • Change frontend port to 3001 as 3000 is taken by backend server

Please review this PR commit by commit (except for the last 2 commit for fixing yarn.lock files)

Type of change

Please delete options that are not relevant.

  • Bug fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run ./start.sh - see all deprecation warnings gone in the terminal
  • Run ./start.sh - see deprecation warning gone browser console

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I added the relevant people as reviewers to my PR

@Alonkad Alonkad changed the title Adding .env file to .gitignore Fixes for initial app setup Feb 13, 2022
@Alonkad Alonkad requested review from vanessa-cooper and removed request for vanessa-cooper February 13, 2022 15:00
Copy link
Member

@vanessa-cooper vanessa-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we still have some problems.
To make it easier for new engineers to get the system up and running, is there a way you can make the readme file a bit more friendly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants