Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run new phpstorm inspections #18

Merged
merged 20 commits into from
Apr 17, 2019
Merged

Run new phpstorm inspections #18

merged 20 commits into from
Apr 17, 2019

Conversation

NanoSector
Copy link
Member

Also fix the issues they report.

@NanoSector
Use list statement wherever possible
b75a4cb 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Declare return type where it was missing
773b6d8 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Remove needless null assignment
3146d14 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Set exception messages where needed
df6741c 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Use strict type checks
5fd86a8 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Use strict type checks (forgot one)
d033f78 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Optimize imports
0f97ec8 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Declare constructor public
d3a6fc6 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
PSR-2 code style please...
7f5be56 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Add php code sniffer to composer.json require-dev
6f661ea 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Use sprintf for exception
616ea2c 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Fix prefix check
9f7a2cf 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Set PSR-2 as preferred code style
13e6f8a 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Move list of allowed commands into a constant
a310edf 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Beautify src/ code
3801c17 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Beautify tests/ code
0d7f437 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Moar inspections
3f9258f 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Declare strict types everywhere
6c8fbb5 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Micro-optimization in Privmsg
b5ccba1 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector
Disable HTML and Typo inspections
7672b6a 
Signed-off-by: NanoSector <rick@nanosector.nl>
@NanoSector NanoSector merged commit 6a2fbaf into master Apr 17, 2019
@NanoSector NanoSector deleted the inspections branch April 21, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NanoSector