Developed .html files and tests for method element(final By locator). #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vefimofff
requested changes
Jul 24, 2017
| public TestElementPage checkAnimationElement() { | ||
| element(By.id("myAnimation")).should().beDisplayed(); | ||
| element(By.id("myAnimation")).should().beDisplayed(); | ||
| element(By.id("myAnimation")).should().beDisplayed(); |
There was a problem hiding this comment.
Not sure i understand the idea of this particular test? What does it really check and in what situation do you expect it to fail? I think the best way would be to provide a comment to this method - explaining the idea of it
| @Autowired | ||
| private TestElementPage testElementPage; | ||
|
|
||
| @Test(expectedExceptions = Exception.class) |
There was a problem hiding this comment.
please specify what exactly exception is expected as Exception is too general
| /** | ||
| * Created by shekhavtsov on 21/07/2017. | ||
| */ | ||
| public class NonexistentElement extends BaseTest { |
There was a problem hiding this comment.
Lets add "ThrowsException" to a class name to make it more friendly
|
@vefimofff I fixed. Plz review: 5f0d434 |
vefimofff
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #12
test for method element(final By locator).