Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The diff of the first line is wrong #99

Closed
mbork opened this issue Jan 17, 2022 · 0 comments
Closed

The diff of the first line is wrong #99

mbork opened this issue Jan 17, 2022 · 0 comments
Labels

Comments

@mbork
Copy link

mbork commented Jan 17, 2022

When diffing two files where the first line was changed, the "old" ("left") one shows an empty line instead. Here is a minimal (or at least fairly small) example:

"old file":

const React = require('react');
console.log('hello world');

"new" file:

import React, {useState} from 'react';
console.log('hello world');

Result of difft old.js new.js:

new.js --- 1/1 --- JavaScript
.                                                                                              1 import React, {useState} from 'react';
2 console.log('hello world');                                                                  2 console.log('hello world');

Note: this looks like it could be connected (or the same) as #90.

I observed this in v0.15.0, but I'm almost sure the output was correct in v0.11.0 (the previous one I used).

Wilfred added a commit that referenced this issue Jan 18, 2022
ap-nri pushed a commit to ap-nri/difftastic that referenced this issue Apr 1, 2022
Wilfred pushed a commit that referenced this issue Apr 18, 2022
Wilfred pushed a commit that referenced this issue Apr 18, 2022
This reverts commit 67d304c, reversing
changes made to 5993f53.
Wilfred pushed a commit that referenced this issue Mar 17, 2023
feat(ci): run build & test action on PRs
Wilfred pushed a commit that referenced this issue Oct 26, 2023
Build WASM binary in normal build workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants