Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for definition after navigation #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wyuenho
Copy link
Contributor

@wyuenho wyuenho commented Oct 8, 2024

Currently when helpful is constructing the navigation button in the helpful buffer, it assumes the position of the definition searched is going to remain the same as after finding file. This assumption cannot hold if the user has an emacs-lisp-mode-hook defined that changes the buffer size, e.g. (indent-region (point-min) (point-max)), so in order to make sure the point is really pointing at the definition, helpful--navigate will have to search again.

This logic is mostly copied from help-mode, which does not have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant