Test gha #1
Open
Test gha #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Will-Lo
added a commit
to linkedin/openhouse
that referenced
this pull request
Dec 17, 2024
…date the correct commit hashes (#269) ## Summary This PR adds a new workflow which largely reuses the existing workflow for building/creating images, except that it runs on pull requests but also uses the correct hashes. The PR workflow also has some optimizations to cancel the previous test run on the same PR if a new commit is pushed since that test result is outdated. <!--- HINT: Replace #nnn with corresponding Issue number, if you are fixing an existing issue --> [Issue](https://github.com/linkedin/openhouse/issues/#nnn)] Briefly discuss the summary of the changes made in this pull request in 2-3 lines. For all the boxes checked, please include additional details of the changes made in this pull request. The workflow on the main branch appears to be using the merge commit SHA for tagging purposes: https://github.com/anothrNick/github-tag-action However this causes issues where it can use outdated hashes of pull requests due to using `github.event.pull_request.merge_commit_sha` which does not seem consistent with the Pull Request HEAD SHA. Documentation on the default behavior here that should fix it https://github.com/actions/checkout/blob/main/README.md This can cause PRs to have breaking commits but due to this workflow file can pass the CI tests, making it difficult to work in the repository. Another side effect of the PR is that committers branches that have multiple commits may have difficulty debugging their failing workflows locally since the CI tests are running on outdated files. See testing below for replication of the issue. ## Changes - [ ] Client-facing API Changes - [ ] Internal API Changes - [x] Bug Fixes - [ ] New Features - [ ] Performance Improvements - [ ] Code Style - [ ] Refactoring - [ ] Documentation - [ ] Tests ## Testing Done <!--- Check any relevant boxes with "x" --> - [ ] Manually Tested on local docker setup. Please include commands ran, and their output. - [ ] Added new tests for the changes made. - [ ] Updated existing tests to reflect the changes made. - [ ] No tests added or updated. Please explain why. If unsure, please feel free to ask for help. - [x] Some other form of testing like staging or soak time in production. Please explain. For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request. Tested locally on my repo Will-Lo#1 shows a PR with the old behavior which has a clearly breaking change, but is passing tests since the commit that opened the PR passed tests Will-Lo#3 shows a PR that used to pass with the commit that opened it, but now fails with the same breaking change. # Additional Information - [ ] Breaking Changes - [ ] Deprecations - [ ] Large PR broken into smaller PRs, and PR plan linked in the description. For all the boxes checked, include additional details of the changes made in this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue] Briefly discuss the summary of the changes made in this
pull request in 2-3 lines.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.