feat: support include directive in GitHub issues / PRs / code blocks #422
+112
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Include directive in PR is also supported! |
kumachan-mis
changed the title
exKAZUu
reviewed
Apr 11, 2020
src/mutator/DescriptionMutator.ts
Outdated
| for (const finder of finders) { | ||
| for (const content of finder.find(webPageUrl, $root)) { | ||
| const $text = content.$text; | ||
| const arraysOfContents = await Promise.all(finders.map((finder) => finder.find(webPageUrl, $root))); |
There was a problem hiding this comment.
This statement waits all the promises, so I feel it is not good performance-wise.
Could we rewrite this as follows?
await Promise.all(finders.map(async (finder) => {
const contents = await finder.find(webPageUrl, $root);
for (const content of contents) {
.. snip ..
}
}));
There was a problem hiding this comment.
Shall I rewrite DiffMutator, too?
exKAZUu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/state.pu