-
-
Notifications
You must be signed in to change notification settings - Fork 18
Add async with timeout to detect extras #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hub.py - Line 555 is currently missing the "f" to mark the string for variable expansion hence "I{self._rr_unit}:" is always logged literally |
hub.py - 1323/1563: Disabling self.global_power_control/self.advanced_power_control on TimeoutError will not allow the entities fixed with PR #824 become available again as it does not longer tries to read the corresponding modbus block or does it? |
They won't come back if the TimeoutError is triggered unless the integration is reloaded. |
This reverts commit 3c8d729.
Commit 0b49bdb fixes this. |
TODO: research how async timeout context interacts with pymodbus timeout and retries and adjust timing if needed. |
Doubling the read context timeout from 3 seconds to 6 seconds for release. |
Attempt to work around reported issues with detection and certain versions of SolarEdge firmware.