Skip to content

Add async with timeout to detect extras #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 7, 2025

Conversation

WillCodeForCats
Copy link
Owner

Attempt to work around reported issues with detection and certain versions of SolarEdge firmware.

@WillCodeForCats WillCodeForCats self-assigned this May 26, 2025
@WillCodeForCats WillCodeForCats added bug Something isn't working update Update or change to something labels May 26, 2025
@Kishi85
Copy link

Kishi85 commented May 29, 2025

hub.py - Line 555 is currently missing the "f" to mark the string for variable expansion hence "I{self._rr_unit}:" is always logged literally

@Kishi85
Copy link

Kishi85 commented May 29, 2025

hub.py - 1323/1563: Disabling self.global_power_control/self.advanced_power_control on TimeoutError will not allow the entities fixed with PR #824 become available again as it does not longer tries to read the corresponding modbus block or does it?

@WillCodeForCats
Copy link
Owner Author

They won't come back if the TimeoutError is triggered unless the integration is reloaded.

@WillCodeForCats
Copy link
Owner Author

They won't come back if the TimeoutError is triggered unless the integration is reloaded.

Commit 0b49bdb fixes this.

@WillCodeForCats
Copy link
Owner Author

TODO: research how async timeout context interacts with pymodbus timeout and retries and adjust timing if needed.

@WillCodeForCats
Copy link
Owner Author

Doubling the read context timeout from 3 seconds to 6 seconds for release.

@WillCodeForCats WillCodeForCats merged commit d7026ef into main Jun 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working update Update or change to something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it more user friendly when the inverter doesn't respond to registers in the power control block
2 participants