Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache bug #252

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Cache bug #252

merged 4 commits into from
Oct 31, 2024

Conversation

alejoroman0605
Copy link
Contributor

Related to Issue #31

Description

During the build of the installer, the files in the Config/ folder HandlerMerge-Add.xml.resources and HandlerMerge-Remove.xml.resources were not being copied. This caused a NullReferenceException in the method responsible for setting and managing the module configuration, preventing the settings from being read and the Open Graph Protocol from being enabled. To resolve this, I modified the ModulePackage.targets file to include these files, which effectively fixed the issue. I also updated the DNN dependencies to 9.11.00.

How Has This Been Tested?

I tested locally

Screenshots (if appropriate):

image
image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@WillStrohl WillStrohl added the bug label Oct 31, 2024
Copy link
Owner

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl added this to the OGP 02.01.00 milestone Oct 31, 2024
@WillStrohl WillStrohl merged commit 9e53291 into WillStrohl:development Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants