Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Midnight.ini #1430

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Create Midnight.ini #1430

merged 3 commits into from
Jul 30, 2022

Conversation

HaroldPetersInskipp
Copy link
Contributor

Added an additional color scheme that is easy on the eyes.

Added an additional color scheme that is easy on the eyes.
@sdottaka
Copy link
Member

Thank you for the PR.

The name "Dark Mode" looks strange compared to the other schema names, so could you please remove the "Mode" and name it something else?

Also, as you can see below, the colors of the folder window and other colors have not changed much from Solarized Dark. Can you make them a little different from Solarized Dark?

image

 Changed The colors of the folder window to better differentiate this scheme from Solarized Dark.
@HaroldPetersInskipp
Copy link
Contributor Author

I have updated and renamed the color scheme to better differentiate it from Solarized Dark.

@sdottaka sdottaka changed the title Create Dark Mode.ini Create Midnight.ini Jul 29, 2022
@sdottaka sdottaka added this to the v2.16.23 milestone Jul 29, 2022
@sdottaka
Copy link
Member

Thank you for updading the file.

The diff items in the folder window are a little hard to see for me, is this OK for you?

image

I've altered the value of the background for diff items in the folder window to better contrast with the text. I didn't want increase the contrast too high here, as that would defeat the purpose of a dark theme, but I think this is a good compromise between ease of readability and lack of eye strain.
@HaroldPetersInskipp
Copy link
Contributor Author

I've altered the value of the background for diff items in the folder window to better contrast with the text. I didn't want increase the contrast too high here, as that would defeat the purpose of a dark theme, but I think this is a good compromise between ease of readability and lack of eye strain.

@sdottaka sdottaka merged commit e3bacb5 into WinMerge:master Jul 30, 2022
@sdottaka
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants