Create thread in shell finalizer (#339)

WinRb · Jun 9, 2024 · 8096de6 · 8096de6
1 parent 3cb67d0
commit 8096de6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/lib/winrm/shells/base.rb b/lib/winrm/shells/base.rb
@@ -183,6 +183,10 @@ def add_finalizer
       def remove_finalizer
         ObjectSpace.undefine_finalizer(self)
       end
+
+      def self.finalize(connection_opts, transport, shell_id)
+        proc { Thread.new { close_shell(connection_opts, transport, shell_id) } }
+      end
     end
   end
 end
diff --git a/lib/winrm/shells/cmd.rb b/lib/winrm/shells/cmd.rb
@@ -20,10 +20,6 @@ module Shells
     class Cmd < Base
       include WinRM::WSMV::SOAP
       class << self
-        def finalize(connection_opts, transport, shell_id)
-          proc { Cmd.close_shell(connection_opts, transport, shell_id) }
-        end
-
         def close_shell(connection_opts, transport, shell_id)
           msg = WinRM::WSMV::CloseShell.new(connection_opts, shell_id: shell_id)
           transport.send_request(msg.build)

diff --git a/lib/winrm/shells/power_shell.rb b/lib/winrm/shells/power_shell.rb
@@ -29,10 +29,6 @@ class Powershell < Base
       include WinRM::WSMV::SOAP
 
       class << self
-        def finalize(connection_opts, transport, shell_id)
-          proc { Powershell.close_shell(connection_opts, transport, shell_id) }
-        end
-
         def close_shell(connection_opts, transport, shell_id)
           msg = WinRM::WSMV::CloseShell.new(
             connection_opts,