Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rexml as an explicit dependency for Ruby 3.x #334

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

postmodern
Copy link
Contributor

  • rexml was removed as a default gem from Ruby 3.x, so we need to add it as an explicit dependency.
  • Restrict the rexml version family to 3.0+. Ruby 2.6 shipped with rexml-3.1.9.1 so this should be compatible.

* rexml was removed as a default gem from Ruby 3.x, so we need to add it as an explicit dependency.
* Restrict the rexml version family to 3.0+. Ruby 2.6 shipped with rexml-3.1.9.1 so this should be compatible.
@postmodern
Copy link
Contributor Author

The rexml dependency could be bumped to ~> 3.1 since Ruby 2.3.0 shipped with 3.1.7.3. https://docs.ruby-lang.org/en/2.3.0/REXML.html

@mwrock mwrock merged commit ef3e56e into WinRb:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants