Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding user-agent option #337

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Adding user-agent option #337

merged 2 commits into from
Apr 26, 2022

Conversation

laxa
Copy link
Contributor

@laxa laxa commented Apr 26, 2022

Fix the issue #336.
It should be noted that there is a slight change regarding the User-Agent with this PR. Before the changement the User-Agent would have been:

User-Agent: Ruby WinRM Client (HTTPClient_LIB_VERSION, ruby VERSION (DATE_VERSION))

After this PR, the User-Agent would simply be: Ruby WinRM Client.

As I am nowhere near the skill of a ruby developer, let me know if my code can be improved (I have run the required tests).

@mwrock
Copy link
Member

mwrock commented Apr 26, 2022

This looks good. Thanks!

@mwrock mwrock merged commit 033b439 into WinRb:master Apr 26, 2022
@laxa
Copy link
Contributor Author

laxa commented Apr 26, 2022

Thanks for the merge. Do you have any idea when a new release would be made? I introduced this PR to use it in another project that depends on WinRM. Cheers,

@laxa
Copy link
Contributor Author

laxa commented Oct 26, 2022

Hello sir, I am wondering if that would be possible to make a release including this fix and to push it on the gem so other projects can use it.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants