Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSpect should => expect modernization #14

Merged
merged 3 commits into from
Dec 9, 2014
Merged

RSpect should => expect modernization #14

merged 3 commits into from
Dec 9, 2014

Conversation

zenchild
Copy link
Member

@zenchild zenchild commented Dec 5, 2014

This will fix deprecated messages in RSpec 3.

@jlee-r7
Copy link

jlee-r7 commented Dec 8, 2014

This should probably set a minimum version for rspec in Gemfile. Expect syntax was finalized in 2.11, according to http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax

@zenchild
Copy link
Member Author

zenchild commented Dec 8, 2014

Good point. Thx @jlee-r7

zenchild added a commit that referenced this pull request Dec 9, 2014
@zenchild
Merge pull request #14 from WinRb/dan/rspec-modernization
a9a02d3 
RSpect should => expect modernization
@zenchild zenchild merged commit a9a02d3 into master Dec 9, 2014
@pcai pcai deleted the dan/rspec-modernization branch June 6, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenchild @jlee-r7