Make the session key available to clients #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Good add. |
zenchild
added a commit
that referenced
this pull request
Jun 17, 2015
Make the session key available to clients
jlee-r7
pushed a commit
to jlee-r7/ruby_smb
that referenced
this pull request
Jul 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MS-NLMP] 3.1.5.1.2 uses
ExportedSessionKeyfor what this code callingmaster_key.SMB2 uses
ExportedSessionKeyas the signing key -- [MS-SMB2] 3.3.5.5.3.This pull request changes the name to match the documentation and makes it a public method so I don't have to reach into the object's privates with
send. (see https://github.com/rapid7/smb2/blob/22156bc405734c48262d4ae23497c3d2b2acb093/lib/smb2/client.rb#L215-L219)