Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix session.workstation when passing only domain #26

Merged
merged 2 commits into from
Jan 22, 2016
Merged

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Jan 20, 2016

This fixes:

C:/Users/MattWrock/AppData/Local/chefdk/gem/ruby/2.1.0/gems/rubyntlm-0.5.2/lib/net/ntlm/encode_util.rb:42:in `encode_utf16le': undefined method `encoding' for nil:NilClass (NoMethodError)

When passing in a :domain option

@mwrock
Copy link
Member Author

mwrock commented Jan 22, 2016

pinging @zenchild or @sneal feel free to add me to this repo/rubygem and I can merge/release if you like.

@zenchild
Copy link
Member

Looks good @mwrock. I also added you to the rubyntlm team so go ahead and merge.

mwrock added a commit that referenced this pull request Jan 22, 2016
fix session.workstation when passing only domain
@mwrock mwrock merged commit cbf8601 into WinRb:master Jan 22, 2016
@mwrock mwrock deleted the domain branch January 22, 2016 16:39
@zenchild
Copy link
Member

I pushed it up, but I also added you as an owner.

@mwrock
Copy link
Member Author

mwrock commented Jan 22, 2016

thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants