Support Extended Protection for Authentication (Channel binding) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| def inject_cbt |
|
This is complete. I'm gonna keep it WIP until I have a PR ready that consumes it in WinRM. I have a "hacked" WinRM using this and working against a VM with its Tests are currently failing for 1.8.7. That was retired almost 3 years ago so I'll remove it in this PR. |
|
PR submitted for WinRM - WinRb/WinRM#186 Before removing WIP, I'm gonna do a sanity check against 2008 (R1) later. Once that checks out I think this will be good to go. |
mwrock
changed the title
|
Looks good to me. Ship it :) |
|
sweet. thanks @zenchild ! squashing. Will release soon. |
mwrock
force-pushed
the
channel_binding
branch
from
e5160bc to
1af7775
Compare
|
|
| @@ -0,0 +1,14 @@ | |||
| module Net | |||
| module Ntlm | |||
There was a problem hiding this comment.
This should be NTLM to match the rest of the code.
There was a problem hiding this comment.
ah yes. thanks for catching @jlee-r7 !
mwrock
force-pushed
the
channel_binding
branch
from
1af7775 to
5cdfb51
Compare
mwrock
added a commit
that referenced
this pull request
Feb 16, 2016
Support Extended Protection for Authentication (Channel binding)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #27
Adds support for Extended Protection for Authentication biinding TLS channel to NTLM authentication.