Update Negotiate Flags #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mwrock
previously requested changes
Jan 26, 2021
There was a problem hiding this comment.
This is probably totally fine, but there is the possibility this could break someone using the removed keys. Might not be a bad idea to keep those at the bottom of the list and commented as undocumented. They may be documented somewhere else since I doubt they were originally added arbitrarily.
|
So, I found out I never pushed the changes for this. I'm sorry for the delay (almost 4 years!). I made the requested changes. |
5 tasks
|
thanks for your contribution @n00tmeg. is this still helpful to merge? I tried spot checking that it matches the documentation but since they're not in the same order it was a bit hard to validate. |
pcai
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Negotiate Flags to match the Microsoft documentation (https://msdn.microsoft.com/en-us/library/cc236650.aspx).
Obs.: MBx (Must Be Zero) flags and other unreferenced flags were removed. Please let me know if you think they should be there, I will put them back.