Refactor/refactor classes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 23, 2013 13:54
first step, move classes into seperate files to allow easier cleanup and refactoring
Circular Dependency between FieldSet and SecurityBuffer
load-order issues resolved
cleanup rake task to simple standard approach
start writing specs for base Field class Look into shared example groups
This will make Field sublcasses easier to test
Int16LE, Int32LE, and Int64LE now have a shared example group. The behaviour is the same the values just change. Much cleaner tests this way.
Keeps you from making a bonehead mistake Mostly jsut makes coverage numbers look better.
probably need to revisit later for other test cases, but this works for now
still need to test instance methods
Shouldn't have more than 1 assertion per it block. This works much better.
probably some more to wrap here, but this gets the basics down for now
FieldSet and Message are a little odd as they don't have fields themselves but as they don't directly affect anything we can kind of kludge around that for now. This self-modifying class stuff seems unnecissary.
one spec failing. committing before i try to fix the behaviour
fixing that test breaks others, leave it for now
Got a ways to go, but should be able to get all the messages speced out with this soon
some wierd inconsistencies between types here. Also confused by what some of these methods are trying to do
Get code coverage working with simplecov
existing message specs mvoed to the right spec files.
Got pulled off this to do other things. add latest fix and bump version. Need to come back and finish adding tests, and fix up YARD documentation later.
added 2 commits
August 16, 2013 10:56
Conflicts: lib/net/ntlm.rb
pry was accidentally left in Gemfile
| it { should respond_to :has_flag? } | ||
| it { should respond_to :set_flag } | ||
| it { should respond_to :dump_flags } | ||
| it { should respond_to :has_flag? } |
added 5 commits
August 16, 2013 11:15
fix few things pointed out by egypt
Some unicode issues that come up in ruby 2.0 and rbx
use pack to derive propper values rather than use string literals. Eliminates wierd encoding issues
rubinius has issues with this routine. Force encoding the passed string as UTF-16 then do our conversion method.
apparently breaks 1.9.2 i hate charachter encoding!
|
hellloooooo? |
|
Sorry. It's been a bust month. I will see if I can review this on Monday for impact. So far I am happy with what I see, though I need to do some manual testing to be sure that it does not break things. I am inclined to merge and bump if the manual testing works out. |
|
heh , no worries. cheers! |
|
@dmaloney-r7 I am stumbling a bit here on the integration testing. I am able to test that local authentication still works with httpclient, however I am not able to verify the same for domain authentication. Have you run this test case? |
|
Okay. I figured it out... The domain ALWAYS has to be in caps. I will fix. Other than that, the merge looks good |
|
awesome, thanks |
|
This has been released at 0.4.0. You rock. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large Refactor of this library. Split classes/modules out into their own seperate file structure
Small bits of cleanup for obviously wrong behaviour
Added lots of tests (now 681 SPECS and counting)
Fixed rake tasks to do rspec and simplecov correctly
Still TODO:
Add more test coverage
Add and clenaup YARD documentation
Add YARD rake task
refactor a few more wonky things once test coverage is in place