Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powershell streams leaking to standard error #19

Merged
merged 2 commits into from
Aug 1, 2015

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Aug 1, 2015

Powershell has several streams. Unless, output is sent to the output stream, winrm interprets the output as error output. There are some module auto loading scenarios where powershell will send information out to the progress stream. This suppresses that stream all together by turning it off.

Also, the checksum script currently writes the hash using write-host. As of powershell v5, output sent using write-host directs some metadata to a new information stream and suffers the same problem as the progress stream where it causes winrm to leak to standard error. This simply replaces write-host with write-output which will be output to stdout and the console.

This fixes #18

mwrock added a commit that referenced this pull request Aug 1, 2015
Fix powershell streams leaking to standard error
@mwrock mwrock merged commit aaeadec into WinRb:master Aug 1, 2015
@sneal
Copy link
Member

sneal commented Aug 1, 2015

Nice job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file upload failed on Win10
2 participants