Add support for secure boot without shim #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling inside lockdown and shim_lock verifieirs with patch is unneeded, as there is already a `--disable-shim-lock`[1] option, which should be used instead. [1] https://www.gnu.org/software/grub/manual/grub/html_node/UEFI-secure-boot-and-shim.html Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
In `meta-signing-key/classes/user-key-store.bbclass` file, there is already an implementation of sb_sign() function with support for both scerarions: - bootloader is verified by shim_cert.crt - shim is not used, and DB.crt is used to verify bootloader directly but when building with MOK_SB ?= "0", grub is being build as `grub(ia32/x64).efi` and with shim_lock support enabled. Disabling shim_lock for running secure boot without shim fixes the issue: error: ../../grub-core/kern/efi/sb.c:180:shim_lock protocol not found. during boot. Disabling renaming of grub efi into `grubx64.efi` leaves it, as it is in EFI_BOOT_IMAGE variable, set in `yocto/openembedded-core/meta/conf/image-uefi.conf`, as this will be our first efi boot file. Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
Packages like shim, seloader etc. are currently being installed always, as packages listed in `packagegroup-efi-secure-boot.bb`. Instead of installing them for each scheme, they should be installed conditionally, as run dependencies of grub-efi package. Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some minor issues with additional changes like: