Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix error message propagation on plugin call failure (nushell#12632)
# Description This should fix the sometimes failing wrong version test for stress_internals. The plugin interface state stores an error if some kind of critical error happened, and this error should be propagated to any future operations on the interface, but this wasn't being propagated to plugin calls that were already waiting. During plugin registration, the wrong version error needs to be received as a response to the `get_signature()` to show up properly, but this would only happen if `get_signature()` started after the `Hello` was already received and processed. That would be a race condition, which this commit solves. cc @sholderbach - this should fix the CI issue # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib`
- Loading branch information