Skip to content

Commit

Permalink
Only release mojmap for now
Browse files Browse the repository at this point in the history 
Since no reason to use reobf jar above 1.20.5
  • Loading branch information
@Dreeam-qwq
Dreeam-qwq committed Jul 27, 2024
1 parent 339a519 commit 6588c2a
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/build-121.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,10 @@ jobs:
run: ./gradlew -Dorg.gradle.jvmargs="-Dgraal.CompilerConfiguration=enterprise -Dgraal.UsePriorityInlining=true -Dgraal.Vectorization=true -Dgraal.OptDuplication=true --add-modules jdk.incubator.vector" applyPatches --stacktrace --no-daemon
- name: Create MojmapPaperclipJar
run: ./gradlew -Dorg.gradle.jvmargs="-Dgraal.CompilerConfiguration=enterprise -Dgraal.UsePriorityInlining=true -Dgraal.Vectorization=true -Dgraal.OptDuplication=true --add-modules jdk.incubator.vector" createMojmapPaperclipJar --stacktrace --no-daemon
- name: Create ReobfPaperclipJar
run: ./gradlew -Dorg.gradle.jvmargs="-Dgraal.CompilerConfiguration=enterprise -Dgraal.UsePriorityInlining=true -Dgraal.Vectorization=true -Dgraal.OptDuplication=true --add-modules jdk.incubator.vector" createReobfPaperclipJar --stacktrace --no-daemon

- name: Rename Paperclip Jar
run: |
mv build/libs/leaf-paperclip-1.21-R0.1-SNAPSHOT-mojmap.jar ./leaf-1.21-mojmap.jar
mv build/libs/leaf-paperclip-1.21-R0.1-SNAPSHOT-reobf.jar ./leaf-1.21-reobf.jar
mv build/libs/leaf-paperclip-1.21-R0.1-SNAPSHOT-mojmap.jar ./leaf-1.21.jar
# Publish manually instead of using workflow
# - name: Publish API
Expand All @@ -51,7 +48,7 @@ jobs:
uses: actions/upload-artifact@main
with:
name: Leaf 1.21
path: ./leaf-1.21-*.jar
path: ./leaf-1.21.jar

- name: Release Leaf
if: github.event_name != 'pull_request'
Expand All @@ -60,5 +57,5 @@ jobs:
title: "Leaf 1.21"
automatic_release_tag: "ver-1.21"
repo_token: "${{ secrets.GITHUB_TOKEN }}"
files: "./leaf-1.21-*.jar"
files: "./leaf-1.21.jar"
prerelease: false

15 comments on commit 6588c2a

@PukPukov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, switching to Plazma.

@PadowYT2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, switching to Plazma.

spigot mapping sucks yk

@PukPukov
Copy link

@PukPukov PukPukov commented on 6588c2a Jul 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, switching to Plazma.

spigot mapping sucks yk

I dont care how much does it suck because I dont use them. For me this is only pain because half of installed plugins on my server do not work with remapping and I am not going to work on fixing issues that arised because someone said that something "sucks" and broke things that worked for years.

@PadowYT2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, switching to Plazma.

spigot mapping sucks yk

I dont care how much does it suck because I dont use them. For me this is only pain because half of my plugins do not work with remapping and I am not going to work on fixing issues that arised because someone said that something "sucks" and broked things that worked for years.

well you can always build yourself

@PukPukov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well you can always build yourself

Probably in the future. For now I have not so much time to fork anything and not so much desire to fight against mojang/paper metastases.

@PukPukov
Copy link

@PukPukov PukPukov commented on 6588c2a Jul 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this not just about me as server dev, this is pain also for plugin devs. Mappings should be in compile time and this is totally stupid to change mappings in runtime causing so much problems. If you dont like spigot mappings you always can setup your build system so you will code with any mappings you want, and the compiled jar will be with technical mappings. On fabric, for example, this is intermediary, as far as I recall, and not mojang mappings.

@PukPukov
Copy link

@PukPukov PukPukov commented on 6588c2a Jul 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there is a legal issue with mojang mappings... Basically there is no legal way now to use NMS, because you can't redistribute mojang mappings, but you will redistribute it if you will distribute plugin compiled against mojang mappings... Very smart move by Paper so Mojang will have legal ability to take down any plugin they want.

@PukPukov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fork it and change it back and enable actions. don't whine

Did you fully read what I already said?

@PukPukov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you an idiot or what?

Only your father.

You have to install another server core now, configure it, but you can fork the project in 1 fucking minute. You're wasting even more time,

Replacing the core takes 3 minutes. I don't have to reconfigure anything because this is all bukkit with almost exactly the same patches. Forking Leaf will require me to constantly update upstream. Building is not a 1 minute action and takes a lot of time.

@Dreeam-qwq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, switching to Plazma.

spigot mapping sucks yk

I dont care how much does it suck because I dont use them. For me this is only pain because half of installed plugins on my server do not work with remapping and I am not going to work on fixing issues that arised because someone said that something "sucks" and broke things that worked for years.

Can you provide error logs?

@Dreeam-qwq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, switching to Plazma.

spigot mapping sucks yk

I dont care how much does it suck because I dont use them. For me this is only pain because half of installed plugins on my server do not work with remapping and I am not going to work on fixing issues that arised because someone said that something "sucks" and broke things that worked for years.

After Paper commit PaperMC/Paper@de8220c, most of plugins, those support 1.21 and use reobf (spigot) mapping, should be auto-remap to mojang mapping without any error or issue. Only some plugins or libs use 'black magic', for example TabooLib, they don't support 1.21 for now.

Please update Leaf 1.21 to latest version and try again, you can make a test server and just copy all of your plugins into it.

@PukPukov
Copy link

@PukPukov PukPukov commented on 6588c2a Jul 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some plugins or libs use 'black magic', for example TabooLib, they don't support 1.21 for now.

Thats the problem. Who tf you are to decide what is black magic and what is not? I am not going to waste my time on server updating because you decided that some practice is bad and broken thing that worked for years. I am just switching to less toxic core, thats it.

Can you provide error logs?

As I already said I have no time right now. I tried to launch it like three of four times, from like a year ago (when paper just started releasing mojmap) to a month ago, all time with updated plugins. Never I succeeded.

@Dreeam-qwq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some plugins or libs use 'black magic', for example TabooLib, they don't support 1.21 for now.

Thats the problem. Who tf you are to decide what is black magic and what is not? I am not going to waste my time on server updating because you decided that some practice is bad and broken thing that worked for years. I am just switching to less toxic core, thats it.

Can you provide error logs?

As I already said I have no time right now. I tried to launch it like three of four times, from like a year ago (when paper just started releasing mojmap) to a month ago, all time with updated plugins. Never I succeeded.

If you think it is wasting time, you can stop updating all of things of your server and stop making a Minecraft server. that's it.

And Leaf is the only core releases reobf jar after Paper using mojmap map, which core is less toxic? spigot?

@PukPukov
Copy link

@PukPukov PukPukov commented on 6588c2a Jul 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it is wasting time, you can stop updating all of things of your server and stop making a Minecraft server. that's it.

I don’t really see the connection between “I don’t want to waste time because some toxic developer wanted me to waste it” and “I don’t want to make a Minecraft server.”. Looks more like you are crying.

And Leaf is the only core releases reobf jar after Paper using mojmap map, which core is less toxic? spigot?

I sayed this in the first comment. And this is not only core, there are plenty of others.

@Dreeam-qwq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it is wasting time, you can stop updating all of things of your server and stop making a Minecraft server. that's it.

I don’t really see the connection between “I don’t want to waste time because some toxic developer wanted me to waste it” and “I don’t want to make a Minecraft server.”. Looks more like you are crying.

And Leaf is the only core releases reobf jar after Paper using mojmap map, which core is less toxic? spigot?

I sayed this in the first comment. And this is not only core, there are plenty of others.

"Looks more like I'm crying"😂

Please sign in to comment.