Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hide specified item components to clients #94

Merged
merged 5 commits into from
Aug 5, 2024
Merged

[Feature] Hide specified item components to clients #94

merged 5 commits into from
Aug 5, 2024

Conversation

TheFloodDragon
Copy link
Contributor

@TheFloodDragon TheFloodDragon commented Aug 4, 2024

From the Comment

Controls whether specified component information is sent to clients.
This may break resource packs and mods that rely on this information.
It needs a component type list, incorrect things will not work.
You can fill it with ["custom_data"] to hide components of CUSTOM_DATA.
Also, it can avoid some frequent client animations.
NOTICE: You must know what you're filling in and how it works! It will handle all items!

WARNING

If you set the value to ["enchantments"], you cannot see any item's enchantments,
also to avoid some frequent client animations,
but the enchantment data is truly in the server.

So, We only recommend filling it with ["custom_data"]

Tests have been done successfully.

@TheFloodDragon TheFloodDragon marked this pull request as draft August 4, 2024 07:38
Stupid~ wrong packet edited. www
@TheFloodDragon TheFloodDragon changed the title [Feature] Hide specified item components from clients [Feature] Hide specified item components to clients Aug 4, 2024
@TheFloodDragon TheFloodDragon marked this pull request as ready for review August 4, 2024 12:00
@HaHaWTH HaHaWTH added the enhancement New feature or request label Aug 4, 2024
@HaHaWTH
Copy link
Member

HaHaWTH commented Aug 4, 2024

dev-imports.txt file change should not be committed i think

@TheFloodDragon
Copy link
Contributor Author

TheFloodDragon commented Aug 4, 2024

dev-imports.txt file change should not be committed i think

Sorry, My bad, I understand this by mistake. I just saw it in the document.

@Dreeam-qwq
Copy link
Member

Thanks!

@Dreeam-qwq Dreeam-qwq merged commit 39d617b into Winds-Studio:ver/1.21 Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants