-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wmp11: add new verb #1489
wmp11: add new verb #1489
Conversation
I've tested with Revelations 2. Seems to be working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change the commit message to something meaningful. For example:
wmp11: add new verb
src/winetricks
Outdated
|
||
# remove builtin placeholders to allow update | ||
rm -f "$W_SYSTEM64_DLLS"/wmvcore.dll "$W_SYSTEM64_DLLS"/wmp.dll | ||
rm -f "$W_PROGRAMS_UNIX/Windows Media Player/wmplayer.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same (could be combined with line above, but separate is okay too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
src/winetricks
Outdated
# Crashes on exit, but otherwise ok; see https://bugs.winehq.org/show_bug.cgi?id=12633 | ||
w_try_cd "$W_CACHE/$W_PACKAGE" | ||
# https://docs.microsoft.com/en-us/windows/win32/wmp/redistributing-windows-media-player-11 | ||
"$WINE" wmp11-windowsxp-x64-enu.exe /q:A /c:"setup_wm.exe /Q /R:N" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add w_try
.
This also unconditionally installs in quiet mode. Those flags should only be passed if W_OPT_UNATTENDED is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add w_try.
Installer tries to install some incompatible things and fails with 126 code at end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Please add a comment.
Updated verb. |
@basxto for now installation works only with silent mode, dunno how to make work in non-silent. |
I've tested it on Proton 5.0-3 with RE Revelations 2, works great thanks! |
src/winetricks
Outdated
w_try_cd "$W_CACHE/$W_PACKAGE" | ||
|
||
# https://docs.microsoft.com/en-us/windows/win32/wmp/redistributing-windows-media-player-11 | ||
if [ "$W_ARCH" = "win32" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could simplify this to:
"${WINE}" wmp11-windowsxp-x86-enu.exe ${wmp11_exe} ${W_OPT_UNATTENDED:+ /q:A /c:"setup_wm.exe /Q /R:N"}
if you add 'wmp11_exe=` for each after w_download.
src/winetricks
Outdated
# Crashes on exit, but otherwise ok; see https://bugs.winehq.org/show_bug.cgi?id=12633 | ||
w_try_cd "$W_CACHE/$W_PACKAGE" | ||
# https://docs.microsoft.com/en-us/windows/win32/wmp/redistributing-windows-media-player-11 | ||
"$WINE" wmp11-windowsxp-x64-enu.exe /q:A /c:"setup_wm.exe /Q /R:N" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Please add a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I made a few more comments.
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
using the last winetricks isn't making the cut for RE6 on my side |
Currently tested with Resident Evil 5/6 in 64-bit prefix with proton.