Move to kotlin #12
Move to kotlin #12
Conversation
| const val FRENCH = "fr" | ||
| const val ARABIC = "ar" | ||
|
|
||
| private var sharedPreferences: SharedPreferences? = null |
There was a problem hiding this comment.
a lateinit sharedPreferences should be more appropriate. don't you think?
There was a problem hiding this comment.
sharedPreferences can be null if a class calls a method (for example the method setLocaleIfNeeded(@language language: String)) without initiating sharedPreferences via the method init(context: Context?)
There was a problem hiding this comment.
OK I see BUT calling init is mandatory. It's a prerequisite to use LocaleHelper. As you can see init is called only once here https://github.com/Wiqaytna-app/wiqaytna_android/pull/12/files#diff-72d398151f1a0977873d51d832bb38f2R33
There was a problem hiding this comment.
What do you think about my previous comment?!
| const val ARABIC = "ar" | ||
|
|
||
| private var sharedPreferences: SharedPreferences? = null | ||
| var currentLocale: String? = null |
There was a problem hiding this comment.
currentLocale can be null if a class does not call the method init(context: Context?), but it should be private
app/src/main/java/covid/trace/morocco/onboarding/OTPFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/covid/trace/morocco/onboarding/RegisterNumberFragment.kt
Show resolved
Hide resolved
No description provided.