l18n,conf: isolate GOOS=windows code #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found when looking at `golang.zx2c4.com/wireguard/windows/conf`, that it fails on linux, do to this bit. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Found when building `golang.zx2c4.com/wireguard/windows/conf` on linux. Pulled the resolve logic from the wgcfg .ToUAPI() Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
changed the title
zx2c4-bot
force-pushed
the
master
branch
27 times, most recently
from
f490951
to
6315b61
Compare
zx2c4-bot
force-pushed
the
master
branch
2 times, most recently
from
2c75584
to
afe8594
Compare
zx2c4-bot
force-pushed
the
master
branch
13 times, most recently
from
dca9737
to
05d1072
Compare
zx2c4-bot
force-pushed
the
master
branch
7 times, most recently
from
2522c0c
to
4776166
Compare
zx2c4-bot
force-pushed
the
master
branch
8 times, most recently
from
cc96c93
to
b1fc806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when building
golang.zx2c4.com/wireguard/windows/confon linux.(This logic would be nice to have not in a platform specific repo. Maybe in
wireguard-goitself?)Signed-off-by: Vincent Batts vbatts@hashbangbash.com