Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MappingConverter to correctly write the Matcher as C# code #1152

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Aug 6, 2024

No description provided.

@StefH StefH added the bug label Aug 6, 2024
@StefH StefH self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 49 lines in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (95573ee) to head (d37d1b3).
Report is 1 commits behind head on master.

Files Patch % Lines
....Matchers.CSharpCode/Matchers/CSharpCodeMatcher.cs 0.00% 8 Missing ⚠️
src/WireMock.Net/Matchers/JSONPathMatcher.cs 20.00% 8 Missing ⚠️
src/WireMock.Net/Serialization/MappingConverter.cs 75.75% 2 Missing and 6 partials ⚠️
src/WireMock.Net/Matchers/NotNullOrEmptyMatcher.cs 0.00% 7 Missing ⚠️
....Net.Tests/Serialization/CustomPathParamMatcher.cs 0.00% 4 Missing ⚠️
...Net/Authentication/AzureADAuthenticationMatcher.cs 0.00% 3 Missing ⚠️
src/WireMock.Net/Matchers/GraphQLMatcher.cs 0.00% 3 Missing ⚠️
src/WireMock.Net/Matchers/MimePartMatcher.cs 50.00% 3 Missing ⚠️
src/WireMock.Net/Matchers/ProtoBufMatcher.cs 0.00% 3 Missing ⚠️
src/WireMock.Net/Matchers/ContentTypeMatcher.cs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
- Coverage   86.58%   86.56%   -0.02%     
==========================================
  Files         427      429       +2     
  Lines       23959    24200     +241     
==========================================
+ Hits        20744    20948     +204     
- Misses       2314     2350      +36     
- Partials      901      902       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StefH StefH changed the title Bug/1151 to code Update MappingConverter to correctly write the Matcher as C# code Aug 6, 2024
@StefH StefH merged commit da10029 into master Aug 27, 2024
10 of 13 checks passed
@StefH StefH deleted the bug/1151-to-code branch August 27, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant