-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix listen on AnyIP for url 0.0.0.0 #1165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
reviewed
Sep 4, 2024
StefH
reviewed
Sep 4, 2024
StefH
reviewed
Sep 4, 2024
StefH
reviewed
Sep 4, 2024
StefH
reviewed
Sep 4, 2024
StefH
reviewed
Sep 4, 2024
StefH
reviewed
Sep 4, 2024
Can you please resolve the comments which you did fix? |
StefH
reviewed
Sep 5, 2024
StefH
reviewed
Sep 5, 2024
test/WireMock.Net.Tests/Facts/IgnoreOnContinuousIntegrationFact.cs
Outdated
Show resolved
Hide resolved
StefH
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls take a look at some extra comments
StefH
reviewed
Sep 5, 2024
StefH
reviewed
Sep 5, 2024
cocoon
commented
Sep 6, 2024
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To listen on all available IPs this fix allows to use the following URL:
I tried to add a test, but I think the test can be improved.
Could be split in a test for IPv4 and IPv6 and maybe the naming is not perfect.
Getting all IPs could be moved into a utility method ...
Feel free to improve afterwards.