Fix JSON parsing of text/plain content type #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
requested changes
Sep 15, 2024
StefH
requested changes
Sep 16, 2024
| @@ -33,12 +33,17 @@ internal static HttpRequestMessage Create(IRequestMessage requestMessage, string | |||
| MediaTypeHeaderValue.TryParse(value, out contentType); | |||
| } | |||
|
|
|||
| httpRequestMessage.Content = requestMessage.BodyData?.DetectedBodyType switch | |||
| var bodyData = requestMessage.BodyData; | |||
| var bodyType = bodyData?.DetectedBodyTypeFromContentType?.ToNullable() | |||
There was a problem hiding this comment.
Probably better and more readable to add a method BodyType GetBodyType() to the BodyData class.
BodyType GetBodyType()
{
if (DetectedBodyTypeFromContentType != null)
{
return DetectedBodyTypeFromContentType;
}
// and so on.....
}There was a problem hiding this comment.
Problem is, here, we get IBodyData from the requestMessage. But I can write a class extension for that interface :)
There was a problem hiding this comment.
Ah. Just FYI, we can't simply check null as the value of DetectedBodyTypeFromContentType is not null, but BodyType.None. That's why I had to write an extension method for assuming null for this value.
StefH
requested changes
Sep 17, 2024
StefH
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am submitting a pull request to address the behavior of request body parsing, as discussed in issue #1168. My fix attempts to correct this behavior.
However, I'm not entirely sure if this fix is appropriate, as I don't fully understand why the current code relies on the body's detected type instead of the body's content type in both the request and response flows. I believe that the correction should prioritize the content type first, using the body's detected type as a fallback. But I'm not aware of all the history behind this implementation.
Could you please provide guidance or suggest any improvements?
Best regards,
Rux