Model table multiple select #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 20, 2016 11:16
aarranz
requested changes
Dec 20, 2016
| @@ -198,7 +198,7 @@ | |||
| 'initialSortColumn': -1, | |||
| 'pageSize': 5, | |||
| 'emptyMessage': utils.gettext('No data available'), | |||
| 'allowMultipleSelect': false | |||
| 'selectionType': "ignore" | |||
There was a problem hiding this comment.
ignore gives the impression that the selection is going to be ignored whereas this mode raises exceptions when trying to select rows (e.g. using the select method). I think that is better to rename this to none
| {id: 1} | ||
| ]; | ||
| table.source.changeElements(data); | ||
| rows = table.wrapperElement.querySelectorAll(".se-model-table-row"); |
There was a problem hiding this comment.
Remove this line as it isn't doing anything useful ;-)
Mognom
force-pushed
the
ModelTableSelect
branch
from
cb4f148
to
6623490
Compare
aarranz
approved these changes
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based upon #207
Refactored row selection to be done by the ModelTable instead of being done by the DataViewer widget.
Allows selection of multiple rows using the control and alt key modifiers to choose the selection behaviour.
Three types of selection behaviour:
Added an event to send the current selection on change.
Requires the DataViewer widget changes done by wirecloud/data-viwer-widget#3 to work with it.