Add js tests for wiring connections #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarranz
requested changes
Oct 11, 2016
| @@ -26,9 +26,9 @@ | |||
|
|
|||
| "use strict"; | |||
|
|
|||
| // ========================================================================= | |||
| // ================================================================================== | |||
| // CLASS DEFINITION | ||
| // ========================================================================= | ||
| // ================================================================================== |
| } | ||
|
|
||
| }); | ||
|
|
||
| // ========================================================================= | ||
| // ================================================================================== |
| // PRIVATE MEMBERS | ||
| // ========================================================================= | ||
| // ================================================================================== |
| @@ -44,178 +44,145 @@ | |||
| * @param {Wiring} wiringEngine | |||
| * [TODO: description] | |||
| */ | |||
| ns.Connection = utils.defineClass({ | |||
|
|
||
| describe("remove()", function () { | ||
|
|
||
| it("should remove after disconnecting endpoints", function () { |
There was a problem hiding this comment.
"should disconnect the connection"
| }); | ||
| }); | ||
|
|
||
| describe("remove()", function () { |
There was a problem hiding this comment.
Missing tests removing a disconnected connection
| expect(callback.calls.count()).toEqual(1); | ||
| }); | ||
|
|
||
| it("should ignore if one of their endpoints is missing", function () { |
There was a problem hiding this comment.
Split into two tests:
"should do nothing if the source is a ghost endpoint"
"should do nothing if the target is a ghost endpoint"
| expect(callback.calls.count()).toEqual(1); | ||
| }); | ||
|
|
||
| it("should ignore if connection is established", function () { |
There was a problem hiding this comment.
"should do nothing if the connection is already established"
| var callback = jasmine.createSpy("callback"); | ||
|
|
||
| connection.addEventListener("establish", callback); | ||
| connection.establish(); |
There was a problem hiding this comment.
establish should support method chaining. Change this line to:
expect(connection.establish()).toBe(connection);
jpajuelo
force-pushed
the
feature/wiring-connections-tests
branch
from
dcc33b8
to
c85df8f
Compare
aarranz
approved these changes
Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.