Wiring editor unittests #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarranz
force-pushed
the
feature/wiring-editor-unittests
branch
3 times, most recently
from
17cef02
to
0e6f53c
Compare
aarranz
force-pushed
the
feature/wiring-editor-unittests
branch
10 times, most recently
from
1a44ecd
to
db1b4a8
Compare
aarranz
force-pushed
the
feature/wiring-editor-unittests
branch
from
db1b4a8
to
475bd91
Compare
… configurations providing invalid connections
…are not tested using unit tests
Before this patch, the wiring editor tests cases are splited into several test cases, making selenium to start and close the browser too often. Moreover, some tests were grouped in a way that they cannot make use of a different feature set. For example, some tests require search indexes while others not, but due those tests using search indexes, all the tests on the test case were forced to use search indexes, causing a big time penality.
aarranz
force-pushed
the
feature/wiring-editor-unittests
branch
2 times, most recently
from
017dd03
to
8648a53
Compare
aarranz
force-pushed
the
feature/wiring-editor-unittests
branch
from
8648a53
to
4d45f6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial set of unit tests for the wiring editor, taking as last objetive removing some of the selenium tests that will be covered by those new unit tests.