Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ability to find current Widgets #398

Merged
merged 8 commits into from
May 21, 2019

Conversation

jason-fox
Copy link
Contributor

This PR alters the documentation to include an online marketplace/listing of a large set of current Widgets compiled against the latest stable version of Node 8. The listing is automatically generated. The Widgets are compiled using the latest develop tip of the codebase.

The idea here is to improve the availability of Wirecloud Widgets by listing them directly in the documentation, and not to rely on *.wgt files to have been added to the releases.

The documentation has also been amended to list further places that Widgets can be found on GitHub.

@jason-fox jason-fox mentioned this pull request Apr 26, 2019
@coveralls
Copy link

coveralls commented Apr 26, 2019

Coverage Status

Coverage increased (+0.009%) to 79.6% when pulling 70a3e5e on jason-fox:feature/widgets into 309d100 on Wirecloud:develop.

Copy link
Member

@aarranz aarranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI Jason, thank you very much for your work.

But here we have some problems, we are for sure not going to upload public components into the WireCloud repository 😉, so I propose you to use links to the released wgt files into widget.md.

@@ -58,9 +58,19 @@ The following screenshot show the "Settings" menu, where you can set workspace f

<img src="../images/user_guide/create_workspace/workspace_settings.png" srcset="../images/user_guide/create_workspace/workspace_settings.png 2x" alt="create_workspace/WorkspaceSettings.png"/>

## Browsing existing open source Widgets on GitHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommended way of searching components (widgets, operators and mashups) MUST be the marketplace support, so this section should be moved later and be the alternative.

Copy link
Contributor Author

@jason-fox jason-fox Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for putting the look-on-github bit first was to ensure that users have the opportunity of downloading fresh sources. May be this can be reworded - something like "getting latest bleeding edge development"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed cca64bb

## Browsing the Marketplace

A mashup tool like WireCloud must support access to **marketplaces**, where people can offer and deal with services made
A mashup tool like WireCloud also supports access to **marketplaces**, where people can offer and deal with services made
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this change should be discarded.

Copy link
Contributor Author

@jason-fox jason-fox Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is to be The recommended way of searching components then we'll need a re-wording - I guess a revert and a link to the "getting latest bleeding edge development" section where ever that ends up.

There needs to be a fresh up-to-date marketplace link as well - could you supply one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: cca64bb

@jason-fox
Copy link
Contributor Author

jason-fox commented Apr 29, 2019

I can link to the released versions where they exist, but not all repos have consistently been released.

For example: https://github.com/Wirecloud/agile-dashboards
contains a lot of useful Widgets but no release has been made. see: Wirecloud/agile-dashboards#5

I expect there are others, but I don't want to update the list manually. I'll add a check for an existing wgt in the other PR and obtain a discrepancy list.

@jason-fox
Copy link
Contributor Author

jason-fox commented Apr 30, 2019

I propose you to use links to the released wgt files into widget.md.

Fixed: f235030 - This lists the available released *.wgt only

* CKAN Source From URL
* CKAN Source
* CKAN to PoIs
* NGSI target
* ECharts widget
@jason-fox
Copy link
Contributor Author

@aarranz - the widgets.md page now includes widgets from the 3 linked issues you have closed. It is up to you whether you want to review and merge this as is or wait for Wirecloud/agile-dashboards#5 - and add the remaining 41 widgets to the list.

When the outstanding agile-dashboards issue is closed, the widget builder PR will also need a minor update, since agile-dashboards contains multiple widgets with different version numbers, but a single overall release version

@aarranz
Copy link
Member

aarranz commented May 6, 2019

Hi Jason,

I've just created a release for the agile-dashboards repository with all those 41 widgets. So, you can go ahead and finish this PR 😄.

@jason-fox
Copy link
Contributor Author

Hi Jason,

I've just created a release for the agile-dashboards repository with all those 41 widgets. So, you can go ahead and finish this PR 😄.

Fixed - 24cace7.

Now you can go head and finish the PR 😄.

And also review #399 which was used to generate the markdown.

@aarranz
Copy link
Member

aarranz commented May 21, 2019

Hi @jason-fox, sorry for the delay on merging this PR. I was very busy with fixing some bugs and improving some details, as well as preparing the FIWARE Global Summit. In fact, we have released some new versions, so I have to review current versions. So, yes I will review PR #399 by using it 😄.

Also, I will update documentation pointing to https://macs.opplafy.eu for now. I'm afraid we will need to make a new release just after today's one.

Thank you very much for you contributions!

@aarranz aarranz merged commit 5659e16 into Wirecloud:develop May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants