Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSONField on Django 2 #453

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fix JSONField on Django 2 #453

merged 2 commits into from
Dec 18, 2019

Conversation

aarranz
Copy link
Member

@aarranz aarranz commented Dec 10, 2019

Django 2.0 removed the Field._get_val_from_obj method. This PR fixes WireCloud implementation of the JSONField implementation by calling value_from_object instead.

@coveralls
Copy link

coveralls commented Dec 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 80.822% when pulling 0faa180 on aarranz:fix/jsonfield-django2 into b15c83f on Wirecloud:develop.

@aarranz aarranz merged commit b053916 into Wirecloud:develop Dec 18, 2019
@aarranz aarranz mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarranz @coveralls